Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #3389 (PageLayout.Pane: Undo deprecation for position prop) #3589

Merged
merged 9 commits into from
Aug 4, 2023
Merged

Revert #3389 (PageLayout.Pane: Undo deprecation for position prop) #3589

merged 9 commits into from
Aug 4, 2023

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Aug 4, 2023 •
edited
Loading

production (before) upgrade branch (after)
Sidebar in hyperlist is on the left Sidebar in hyperlist is on the left Sidebar in hyperlist is on the right Sidebar in hyperlist is on the right

We would need to bring this change back in a way that it allows new behaviour without breaking existing behaviour.

  • Sidenote: It seems like the same pull request number is also merged in next-major? Link to next-major release tracking That seems very fishy? Was this not supposed to be in main at all?

@siddharthkp siddharthkp requested review from a team and broccolinisoup August 4, 2023 14:26
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3c49ffd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp requested review from joshblack and removed request for broccolinisoup August 4, 2023 14:27
@siddharthkp siddharthkp changed the title Revert #3389 (Deprecate position prop for PageLayout.Pane) Revert #3389 (PageLayout.Pane: Undo deprecation for position prop) Aug 4, 2023
@siddharthkp
Copy link
Member Author

siddharthkp commented Aug 4, 2023 •
edited
Loading

FYI @radglob @broccolinisoup, sorry! :(

@siddharthkp siddharthkp self-assigned this Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 103.67 KB (-0.02% 🔽)
dist/browser.umd.js 104.21 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-3589 August 4, 2023 14:33 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages August 4, 2023 14:35 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3589 August 4, 2023 14:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3589 August 4, 2023 14:36 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages August 4, 2023 14:43 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3589 August 4, 2023 14:44 Inactive
@siddharthkp siddharthkp added update snapshots patch release bug fixes, docs, housekeeping labels Aug 4, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview-3589 August 4, 2023 15:06 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages August 4, 2023 15:09 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3589 August 4, 2023 15:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3589 August 4, 2023 15:30 Inactive
@siddharthkp siddharthkp added this pull request to the merge queue Aug 4, 2023
Merged via the queue into main with commit d598a53 Aug 4, 2023
@siddharthkp siddharthkp deleted the revert-3389 branch August 4, 2023 16:05
@primer-css primer-css mentioned this pull request Aug 3, 2023
Merged
siddharthkp added a commit that referenced this pull request Aug 7, 2023
@siddharthkp
Revert "Revert #3389 (PageLayout.Pane: Undo deprecation for position …
222fb7d 
…prop) (#3589)"

This reverts commit d598a53.
@siddharthkp siddharthkp mentioned this pull request Aug 7, 2023
Closed
@skemex skemex mentioned this pull request May 24, 2024
Open
@rbragaru rbragaru mentioned this pull request Aug 14, 2024
Open
@skemex skemex mentioned this pull request Sep 24, 2024
Open
@skemex skemex mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees

@siddharthkp siddharthkp

Labels
patch release bug fixes, docs, housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkp @langermank